Skip to content

[xharness] Improve process killing a bit. #9120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 1 commit into from
Jul 17, 2020
Merged

[xharness] Improve process killing a bit. #9120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Execution/ProcessManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,12 +277,19 @@ static async Task KillTreeAsyncInternal (int pid, ILog log, bool? diagnostics =

// Send SIGABRT since that produces a crash report
// lldb may fail to attach to system processes, but crash reports will still be produced with potentially helpful stack traces.
for (int i = 0; i < pids.Count; i++)
for (int i = 0; i < pids.Count; i++) {
log.WriteLine ($"kill -6 {pids [i]}");
kill (pids [i], 6);
}

// Wait a little bit for the OS to process the SIGABRTs
await Task.Delay (TimeSpan.FromSeconds (5));

// send kill -9 anyway as a last resort
for (int i = 0; i < pids.Count; i++)
for (int i = 0; i < pids.Count; i++) {
log.WriteLine ($"kill -9 {pids [i]}");
kill (pids [i], 9);
}
}

static async Task<bool> WaitForExitAsync (Process process, TimeSpan? timeout = null)
Expand Down