Skip to content

[xharness] Allow for null environment variables to mlaunch. #9140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 2 commits into from
Jul 22, 2020
Merged

[xharness] Allow for null environment variables to mlaunch. #9140

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eddc569
[xharness] Allow for null environment variables to mlaunch.
rolfbjarne Jul 20, 2020
76c095e
Use ToLowerInvariant instead of ToLower.
rolfbjarne Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/Execution/Mlaunch/Arguments.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,11 @@ public sealed class SetEnvVariableArgument : MlaunchArgument {
public SetEnvVariableArgument (string variableName, object variableValue)
{
this.variableName = variableName ?? throw new ArgumentNullException (nameof (variableName));
this.variableValue = variableValue?.ToString () ?? throw new ArgumentNullException (nameof (variableValue));

if (variableValue is bool)
this.variableValue = this.variableValue.ToLower ();
if (variableValue is bool b)
this.variableValue = b.ToString ().ToLowerInvariant ();
else
this.variableValue = variableValue?.ToString ();
}

public override string AsCommandLineArgument () => Escape ($"-setenv={variableName}={variableValue}");
Expand Down