[msbuild] Emit binding resources to the EmbeddedResource item group instead of ManifestResourceWithNoCulture. Fixes #3876. #9525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of ManifestResourceWithNoCulture. Fixes dotnet#3876. Fixes this warning: warning MSB9004: ManifestResourceWithNoCulture item type is deprecated. Emit EmbeddedResource items instead, with metadata WithCulture='false', Type='Resx', and optional LogicalName. There is a slight difference with regards to the warning message: the Type metadata is set to 'Non-Resx' instead of 'Resx' (because these resources aren't resx files). Fixes dotnet#3876.
rolfbjarne
added
not-notes-worthy
Collaborator
|
Build failure Test results3 tests failed, 93 tests passed.Failed tests
|
Member
Author
|
Test failures are unrelated
|
mandel-macaque
approved these changes
Aug 27, 2020
|
|
||
| Assert.False (logs.Item1.Contains ("CS1685"), "Binding should not contains CS1685 multiple definition warning:\n" + logs.Item1); | ||
|
|
||
| Assert.False (logs.Item1.Contains ("MSB9004"), "Binding should not contains MSB9004 warning:\n" + logs.Item1); |
Contributor
There was a problem hiding this comment.
I know we all use english. But if we have a bot configured to spanish and we land translations, we are going to have issues :/
Nothing really to be changed in this PR, but I've got the feeling this is going to hit us in the future.
Contributor
There was a problem hiding this comment.
We have about a million of these in mmp/msbuild ios-msbuild tests.
If nothing else, we can use environmental variables to force language to test this (and hopefully translation as well).
emaf
approved these changes
Aug 27, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this warning:
There is a slight difference with regards to the warning message: the Type
metadata is set to 'Non-Resx' instead of 'Resx' (because these resources
aren't resx files).
Fixes #3876.