Skip to content

[tests] Skip the TypeDescriptorCanary test in .NET. #9527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 1 commit into from
Aug 27, 2020
Merged

[tests] Skip the TypeDescriptorCanary test in .NET. #9527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions tests/linker/CommonDontLinkTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ namespace DontLink {
[TestFixture]
public class CommonDontLinkTest {

#if NET
[Ignore ("This test accesses internal implementation details for TypeConverters, which has changed in .NET.")]
#endif
[Test]
public void TypeDescriptorCanary ()
{
Expand All @@ -22,12 +25,7 @@ public void TypeDescriptorCanary ()
var ht = (Hashtable) p.GetGetMethod (true).Invoke (null, null);
Assert.NotNull (ht, "Hashtable");

#if NET
var expectedCount = 28;
#else
var expectedCount = 26;
#endif
Assert.That (ht.Count, Is.EqualTo (expectedCount), "Count");
Assert.That (ht.Count, Is.EqualTo (26), "Count");

foreach (var item in ht.Values) {
var name = item.ToString ();
Expand Down Expand Up @@ -57,10 +55,6 @@ public void TypeDescriptorCanary ()
case "System.ComponentModel.UInt32Converter":
case "System.ComponentModel.ByteConverter":
case "System.ComponentModel.EnumConverter":
#if NET
case "System.ComponentModel.VersionConverter":
case "System.UriTypeConverter":
#endif
break;
default:
Assert.Fail ($"Unknown type descriptor {name}");
Expand Down