[msbuild] Merge the CodesignNativeLibraries task into the Codesign task. #9731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge the CodesignNativeLibraries task into the Codesign task, since they're almost identical (so this turns out to be a significant code reduction). * Add a StampPath property to Codesign task, which, if set, specifies if and where a stamp file should be created for each signed file/directory. This replaces the IntermediateOutputPath property from the CodesignNativeLibraries task. * Copy logic to detect if a file/directory needs to be resigned from the CodesignNativeLibraries task to the Codesign task, using any stamp files. * Use the more descriptive error messages E0004/E0005 from the CodesignNativeLibraries task. * The CodesignNativeLibraries task recursed into directories to find *.dylibs and *.metallib files to sign; replace this with MSBuild item group globbing.
rolfbjarne
added
the
skip-public-jenkins
Collaborator
|
Build success |
Member
Author
|
Test failures are unrelated
|
spouliot
approved these changes
Sep 30, 2020
dalexsoto
approved these changes
Sep 30, 2020
chamons
approved these changes
Sep 30, 2020
whitneyschmidt
approved these changes
Sep 30, 2020
emaf
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the CodesignNativeLibraries task into the Codesign task, since they're almost
identical (so this turns out to be a significant code reduction).
a stamp file should be created for each signed file/directory. This replaces the
IntermediateOutputPath property from the CodesignNativeLibraries task.
task to the Codesign task, using any stamp files.
task.
*.metallib files to sign; replace this with MSBuild item group globbing.