Skip to content

Improve version maintenance agentic workflow#262

Merged
ViktorHofer merged 2 commits intomainfrom
improve-version-maintenance-workflow
Mar 10, 2026
Merged

Improve version maintenance agentic workflow#262
ViktorHofer merged 2 commits intomainfrom
improve-version-maintenance-workflow

Conversation

@ViktorHofer
Copy link
Copy Markdown
Member

Fixes issues from the first run of the version maintenance workflow (https://github.com/dotnet/maintenance-packages/actions/runs/22864461699):

Changes

  • Fix NuGet API calls - Use curl instead of Python's urllib.request for proxy/SSL compatibility in the sandboxed AWF container. The previous run failed to update PackageValidationBaselineVersion because urllib.request couldn't complete SSL handshakes through the Squid CONNECT-tunnel proxy.
  • Add runtimes - Declare Python 3.x and .NET 8.0 in the workflow frontmatter (replaces copilot-setup-steps.yml).
  • Fix VersionPrefix logic - Unconditional VersionPrefix is now set to the latest NuGet version (same as PackageValidationBaselineVersion); conditional VersionPrefix with Condition is patch-incremented as before.
  • Conditional AssemblyVersion bumps - Only increment AssemblyVersion when a VersionPrefix in the same file was actually changed.
  • Schedule - Changed from daily to weekly.
  • PR body formatting - Use package names instead of full file paths in the summary table.

ViktorHofer and others added 2 commits March 9, 2026 18:51
- Fix NuGet API calls: use curl instead of urllib.request for proxy/SSL
  compatibility in the sandboxed AWF container
- Add Python and .NET runtimes to workflow frontmatter
- Distinguish unconditional vs conditional VersionPrefix: unconditional
  is set to latest NuGet version, conditional is patch-incremented
- Only bump AssemblyVersion when VersionPrefix actually changes
- Change schedule from daily to weekly
- Use package names instead of file paths in PR summary table
- Remove copilot-setup-steps.yml (replaced by runtimes frontmatter)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…rect

The conditional VersionPrefix is now set to bump_patch(latest_nuget_version)
rather than blindly incrementing its current value. If it already has the
correct value, no change is made.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ViktorHofer ViktorHofer requested a review from ericstj March 9, 2026 18:36
@ViktorHofer ViktorHofer enabled auto-merge (squash) March 9, 2026 18:36
Comment thread .github/workflows/version-maintenance.md
@ViktorHofer ViktorHofer disabled auto-merge March 10, 2026 14:10
Copy link
Copy Markdown
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a whole lot more text for the simple rule of "If IsPackable is true, and the Packable version exists on nuget, set IsPackable to false and increment all versions within the servicing property group in the same file". Can we try leaving it minimal and just referencing a "good" example commit?

@ViktorHofer
Copy link
Copy Markdown
Member Author

Feel free to push into this PR with a simplified version. I didn't write this myself, this is the output of an LLM prompt. Most other agentic workflows that we are building in other repos also tend to be more verbose.

Copy link
Copy Markdown
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK if it works, just more verbose than I'd prefer. I remember when you pushed for this versioning scheme when creating maintenance-packages you had in mind a very simple set of rules for incrementing.

@ViktorHofer
Copy link
Copy Markdown
Member Author

These are instructions for an LLM running as part of gh agentic workflows under a restrictive environment - not for a human. Most of the prompt is handling these special requirements, i.e. providing a script and explaining how to handle the firewall section. The actual rules are roughly 10 sentences.

@ViktorHofer ViktorHofer merged commit 3865f9c into main Mar 10, 2026
5 checks passed
@ViktorHofer ViktorHofer deleted the improve-version-maintenance-workflow branch March 10, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants