Bug when using MSBuild with custom target since NET5.0 update

[theolivenbaum]

Issue Description

I'm hitting a bug when consuming a custom project SDK target (http://nuget.org/packages/h5.target):

Invalid static method invocation syntax: "[MSBuild]::GetTargetFrameworkVersion('$(TargetFramework)', 2)". Method '[MSBuild]::GetTargetFrameworkVersion' not found. Static method invocation should be of the form: $([FullTypeName]::Method()), e.g. $([System.IO.Path]::Combine(`a`, `b`)). Check that all parameters are defined, are of the correct type, and are specified in the right order.  C:\Program Files\dotnet\sdk\5.0.100\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.TargetFrameworkInference.targets

The code in the targets file that seems to be triggering this issue is the following:

  <PropertyGroup Condition="'$(TargetFramework)' != '' and ('$(TargetFrameworkIdentifier)' == '' or '$(TargetFrameworkVersion)' == '')">

    <TargetFrameworkIdentifier>$([MSBuild]::GetTargetFrameworkIdentifier('$(TargetFramework)'))</TargetFrameworkIdentifier>
    <TargetFrameworkVersion>v$([MSBuild]::GetTargetFrameworkVersion('$(TargetFramework)', 2))</TargetFrameworkVersion>
  </PropertyGroup>

If I manually force the properties to the expected (or dummy) values, so that we avoid the GetTargetFrameworkIdentifier, GetTargetFrameworkVersion, GetTargetPlatformIdentifier and GetTargetPlatformVersion calls above:

    <TargetFrameworkIdentifier>.NETStandard</TargetFrameworkIdentifier>
    <TargetFrameworkVersion>v2.0</TargetFrameworkVersion>
    <TargetPlatformIdentifier>h5</TargetPlatformIdentifier>
    <TargetPlatformVersion>2.0</TargetPlatformVersion>

Then the compilation using MSBuild works fine.

Any ideas?

[benvillalobos]

Team Triage: Can you confirm the versions of MSBuild and SDK you're using? It sounds like you're using an older MSBuild with a newer SDK.

[theolivenbaum]

I thought that was the case, but if I enumerate the MSBuild version being found and selected by the MSBuildLocator, it correctly points to the 5.0.100 one under the dotnet/sdks folder.

…

On Wed, Nov 11, 2020, 5:50 PM Ben Villalobos ***@***.***> wrote: Team Triage: Can you confirm the versions of MSBuild and SDK you're using? It sounds like you're using an older MSBuild with a newer SDK. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5875 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACDCOA3B663VLZVNOHI4CX3SPK6FTANCNFSM4TR63KUA> .

[benvillalobos]

Very strange, can you post the output of dotnet msbuild --version from your 5.0.100 sdk?

I can't seem to repro it from sdk version 5.0.100-rc.2.20479.15 that's using MSBuild version 16.8.0-preview-20475-05+aed5e7ed0

[jibsaram]

I'm getting the same issue for a project that is targeting net45:

/usr/share/dotnet/sdk/5.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(5,5): Error MSB4186: Invalid static method invocation syntax: "[MSBuild]::GetTargetFrameworkIdentifier('$(TargetFramework)')". Method '[MSBuild]::GetTargetFrameworkIdentifier' not found. Static method invocation should be of the form: $([FullTypeName]::Method()), e.g. $([System.IO.Path]::Combine(`a`, `b`)). Check that all parameters are defined, are of the correct type, and are specified in the right order. (MSB4186) (SMAPI.ModBuildConfig.Analyzer)
/usr/share/dotnet/sdk/5.0.100/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(5,5): Error MSB4186: Invalid static method invocation syntax: "[MSBuild]::GetTargetFrameworkIdentifier('$(TargetFramework)')". Method '[MSBuild]::GetTargetFrameworkIdentifier' not found. Static method invocation should be of the form: $([FullTypeName]::Method()), e.g. $([System.IO.Path]::Combine(`a`, `b`)). Check that all parameters are defined, are of the correct type, and are specified in the right order. (MSB4186) (SMAPI.Toolkit.CoreInterfaces)

> dotnet --version
5.0.100
> msbuild -version
16.6.0.32601%

The Project Options view in Monodevelop (7.8.4 (build 2)) actually shows the same oddness:

[emmanuel128]

Hi,

I'm getting the same error as @hellodeibu on Visual Studio for Mac. I have a project is targeting net48 and the Xamarin project is targeting netstandard2.0.

Does anyone have a solution?

Edit:

• dotnet -- version : 5.0.100
• msbuild --version : 16.6.0

[benvillalobos]

@emmanuel128 @hellodeibu could you post specifically your dotnet msbuild --version? Info? As typically msbuild -version points to the msbuild installed by visual studio rather than the msbuild packed along with the sdk

[jibsaram]

@benvillalobos apologies for not including that too:

> dotnet --version
5.0.100
> msbuild -version
16.6.0.32601%
> dotnet msbuild -version
16.8.0.52002% 

Just in case this helps too: this is on Ubuntu 20.04 and with MonoDevelop 7.8.4 (build 2) installed.

Edit: small addendum; I had completely removed and re-installed mono-related packages a few times, trying out different repositories and versions and whatnot. I ended with the nightly repository but I don't think there's anything in there that's newer than whatever is in preview. I had the same results (failed to build, Monodevelop showing that odd string, etc.) with the stable-bionic source (stable-focal does not yet contain Monodevelop).

I have removed and re-installed everything mono related from stable-bionic and I'm getting the same versions as shown above.

[theolivenbaum]

Same here, using the latest stable release of VS2019 Enterprise on Windows:

**********************************************************************
** Visual Studio 2019 Developer Command Prompt v16.8.0
** Copyright (c) 2020 Microsoft Corporation
**********************************************************************

>msbuild -version
Microsoft (R) Build Engine version 16.8.1+bd2ea1e3c for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.

16.8.1.52902
>dotnet msbuild -version
Microsoft (R) Build Engine version 16.8.0+126527ff1 for .NET
Copyright (C) Microsoft Corporation. All rights reserved.

16.8.0.52002
>dotnet --version
5.0.100

Also in my case this happens when calling MSBuild programmatically with the h5 compiler.

[benvillalobos]

We're curious if this may be a GAC issue. Please try repairing Visual Studio. This will at least eliminate that possibility.

[benvillalobos]

For those on Mono, this might be because Mono needs to be updated. Here is an issue tracking this: mono/mono#20250