Release MSBuild 17.1

[rainersigwald]

• Create darc channel for VS 17.2 if it doesn't already exist
  darc add-channel --name "VS 17.2"
• Associate the next release branch with the next release channel
  darc add-default-channel --channel "VS 17.2" --branch vs17.2 --repo https://github.com/dotnet/msbuild
• Remove the main to old release channel default channel
  darc delete-default-channel --repo https://github.com/dotnet/msbuild --branch main --channel "VS 17.1"
• Associate the main branch with the next release channel
  darc add-default-channel --channel "VS 17.2" --branch main --repo https://github.com/dotnet/msbuild
• Check subscriptions for the current channel VS 17.1 and update as necessary (for instance, SDK's main branch should usually be updated
  darc get-subscriptions --exact --source-repo https://github.com/dotnet/msbuild --channel "VS 17.1"
• Ensure that the current release channel is associated with the correct release branch
  darc get-default-channels --source-repo https://github.com/dotnet/msbuild --branch vs17.1
• Fast-forward merge the correct commit to the vs17.1 branch
  git push upstream 797fd829a374a880f63fd4eea4ea6990404c48f4:refs/heads/vs17.1
• Prepare final branding PR for vs17.1 but ⚠️ DO NOT CHECK IN YET ⚠️ 17.1 final branding #7225
• Promote unshipped public API to shipped in main
  1. Get-ChildItem -r src/PublicAPI.*.txt | Clear-Content
  2. Open MSBuild.sln in Visual Studio, let it settle
  3. Find a green squiggle for the analyzer and fix all in solution
  4. Get-ChildItem -r PublicAPI.Unshipped.txt | % { Move-Item -Force -Path $_ (Join-Path $_.Directory.FullName "PublicAPI.Shipped.txt") && New-Item $_ }
• Create 17.2 branding PR, including public API change 17.2 branding #7224
• Merge 17.2 branding PR
• Prepare QB-mode bug for final branding insertion in internal VS repo
• Update internal "create VS PR for insertion" release to point to the new VS release branch by default
• Merge final branding to vs17.1 branch
• Get QB approval
• Merge to VS
• ASAP after release, push packages to nuget.org (not currently automated, contact dnceng)
• Update main subscriptions to the new channel (this can be done after release)
  darc get-subscriptions --exact --target-repo https://github.com/dotnet/msbuild --target-branch main

[Forgind]

Do we also need to update our subscriptions?

https://github.com/nuget/nuget.client (VS 17.1) ==> 'https://github.com/dotnet/msbuild' ('main')

for example

[Forgind]

How do we promote unshipped public API to shipped? Not sure I've done that before. Manual cut-paste?

[rainersigwald]

Do we also need to update our subscriptions?

https://github.com/nuget/nuget.client (VS 17.1) ==> 'https://github.com/dotnet/msbuild' ('main')

for example

Yes! Added.

[rainersigwald]

How do we promote unshipped public API to shipped? Not sure I've done that before. Manual cut-paste?

Looks like copy/paste is indeed the way: dotnet/roslyn-analyzers#3448.

[rainersigwald]

Got better instructions on the final API and put them in the OP and the linked issue. Also added that change to #7225.

[Forgind]

So it sounds like we should also add "update things subscribed to us"? I would've thought that was their job?

[KirillOsenkov]

don't forget publish to nuget.org

[ladipro]

cc @rokonec as 17.1 may GA during his kitten.

[marcpopMSFT]

@dotnet/kitten can you update the darc subscriptions so we can close this out? They are still on 17.1.

[KirillOsenkov]

Don't forget to publish to nuget.org 😛