Fix legacy msbuild issues#1
Closed
robashton wants to merge 1 commit intodotnet:masterfrom
robashton:master
Closed
Conversation
Contributor
|
Not quite in the right spirit of this project. But please do feel free to create issues so we (or someone else) can address them. Thanks! |
|
This PR makes me depressed. I guess it was intended as a joke but I only get sad. |
|
Agreed. I don't like this as a joke. Glad to see you open source your stuff, MS. |
Author
|
|
|
I think GitHub is not the right place for humour... |
|
+1 for this feature! Let's call is msbake ;) |
|
@robashton Why don't you get working on that and submit a pull request when it's ready for preview. Or do you just want to be a prick/troll? |
|
@charlesnw1 technically that's bullying - why so aggressive? It may be a legitimate request |
dannyvv
pushed a commit
that referenced
this pull request
Mar 29, 2015
Remove some unreachable and redundant code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSBuild has caused me years of pain, replacing it with Make is probably sensible. 👍