Merged
Conversation
9 tasks
Member
|
For changes featured in ChangeWaves please update the changewave doc. |
SimaTian
reviewed
Nov 26, 2024
SimaTian
reviewed
Nov 26, 2024
SimaTian
reviewed
Nov 26, 2024
SimaTian
approved these changes
Nov 26, 2024
This was referenced Mar 19, 2025
|
This code seems to be deployed with MSBuild version 17.13.19+0d9f5a35a for .NET Framework. Why isn't the https://learn.microsoft.com/en-us/visualstudio/msbuild/change-waves?view=vs-2022 document up to date with the commits in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10536
Contributes to #10996
Context
Custom culture on EmbeddedResource items is supported by
AssignTask(from #10026), but it's then ignored by RAR task (and CreateManifestResourceName as well)Changes Made
We are no more checking the recoginzed culture against the known list. Putting this behind changewave - as it has pottential to break esoteric scenarios of binaries with .resource.dll existing in subdirs, but actually not being a satelite assemblies
Testing
Manual testing on a scenario from the bug
Tailored tests added in #11023 (will be uncommented after merging this PR)