[main] Update dependencies from dotnet/source-build-reference-packages

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-reference-packages

• Subscription: e057db7e-4db9-428b-995f-4479ba5f811f
• Build: 20250106.2
• Date Produced: January 6, 2025 5:10:05 PM UTC
• Commit: 72009fb6ce7327430539004be1dcbfb6fb88adab
• Branch: refs/heads/main

• Updates:
  • Microsoft.SourceBuild.Intermediate.source-build-reference-packages: from 9.0.0-alpha.1.24619.1 to 10.0.605602

[JanProvaznik]

@JanKrivanek it passes and would unblock the Telemetry PR. https://github.com/dotnet/msbuild/pull/11084/checks?check_run_id=35255021078
There is a precedent for taking source-build-reference-packages version 10.x.y even for repos comprising net9 sdk. Roslyn: vs17.12 https://github.com/dotnet/roslyn/blob/da7c6c4257b2f661024b9a506773372a09023eee/eng/Version.Details.xml#L11 , arcade https://github.com/dotnet/arcade/blob/release/9.0/eng/Version.Details.xml#L163
@MichaelSimons is this concerning?

[MichaelSimons]

There is a precedent for taking source-build-reference-packages version 10.x.y even for repos comprising net9 sdk. Roslyn: vs17.12 https://github.com/dotnet/roslyn/blob/da7c6c4257b2f661024b9a506773372a09023eee/eng/Version.Details.xml#L11 , arcade https://github.com/dotnet/arcade/blob/release/9.0/eng/Version.Details.xml#L163
@MichaelSimons is this concerning?

I had previously asked this question here - The response was that there were no plans for it for flow to the 9.0 sdk. This is when I made the SBRP suggestion.

If this branch is flowing to 9.0 sdk then yes this is going to be a problem. The two referenced precedents should not be followed. The two referenced precedents look like flow mistakes. I will work to correct these. If you take a dependency on 10 SBRP in a component that flows to an earlier sdk it has the potential to break source-build. It will cause problems when packages are being referenced from the newer SBRP version but not the older SBRP version. Instead of using SBRP, you would need to declare a darc dependendency on System.Diagnostics.DiagnosticSource so that the "live" version is used.

cc @dotnet/source-build for visibility.

[JanProvaznik]

Sorry for the miscommunication from our side (we did not realize 9.0 includes the possible future 9.0.3xx release that MSBuild main flows to AFAIK) and thanks for the guidance.

[JanKrivanek]

Thank you @MichaelSimons
It was my mistake - I haven't realized that dev17.14 will still be shipping with 9.0.Yxx. So yes - this will flow to 9.0.

Let's then use darc add-dependency - as used here: #11231

For that PR - I just suggested wrong repo (https://github.com/dotnet/runtime instead of https://dev.azure.com/dnceng/internal/_git/dotnet-runtime). Plus I'm bit confused on how to handle the SHA - should it somehow flow automatically eventually, or do we need to add this manually ourselves (e.g by finding the latest commit fro that lib in release/9.0 - https://github.com/dotnet/runtime/tree/release/9.0/src/libraries/System.Diagnostics.DiagnosticSource/src - which would be 981a85989d49daee6b2147113b7de639f5e5d903?)

[JanProvaznik]

I tried adding the depenency with darc add-dependency --name System.Diagnostics.DiagnosticSource -v 9.0.0 -t product -r https://dev.azure.com/dnceng/internal/_git/dotnet-runtime with and without the suggested SHA.
It still fails, not sure what we're doing wrong.
https://github.com/dotnet/msbuild/pull/11084/checks?check_run_id=35313376772