Fix SdkResult Evalution when ProjectRootElement is null#11627
Closed
surayya-MS wants to merge 7 commits intodotnet:mainfrom
Closed
Fix SdkResult Evalution when ProjectRootElement is null#11627surayya-MS wants to merge 7 commits intodotnet:mainfrom
SdkResult Evalution when ProjectRootElement is null#11627surayya-MS wants to merge 7 commits intodotnet:mainfrom
Conversation
…: Build ID 11081403
…: Build ID 11098688 (dotnet#11501) This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.
…h properties and items
YuliiaKovalova
approved these changes
Mar 26, 2025
Member
Author
|
I meant to target vs17.13 not main #11628 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11550
Context
This is a regression caused by changes in
MSBuildSdkResolverthat were introduced in dotnet/sdk#45364. Specifically by adding 2 new properties.This results in hitting the path that was not hit before - handling properties and items of
SdkResult:msbuild/src/Build/Evaluation/Evaluator.cs
Lines 1867 to 1875 in 6aeb262
When
Projectis created fromXmlReaderand not fromProjectRootElement, it results in nullProjectRootElementduring Evaluation. Which results in internal exception likeInternalErrorException: MSB0001: Internal MSBuild Error: .SdkResolver.1981936763.proj unexpectedly not a rooted pathhere:msbuild/src/Build/Evaluation/Evaluator.cs
Line 1928 in 6aeb262
Above created project path is just
.SdkResolver.1981936763.projwith no directory. Later exception is thrown here because of it:msbuild/src/Build/Evaluation/ProjectRootElementCache.cs
Line 262 in 9e51a07
or here if you use
SimpleProjectRootElementCache:msbuild/src/Build/Evaluation/SimpleProjectRootElementCache.cs
Line 43 in 9e51a07
Changes Made
Changed the projet path that is created for
SdkResultproperties and items - if there is noProjectRootElementthen generate name like{Guid}.SdkResolver.{propertiesAndItemsHash}.projin the current directory.Testing
Added test. Tested manually as well
Notes