Skip to content

Update Ngen Priorities for VS#11632

Merged
YuliiaKovalova merged 1 commit intodotnet:vs17.14from
AlexDelepine:patch-1
Mar 31, 2025
Merged

Update Ngen Priorities for VS#11632
YuliiaKovalova merged 1 commit intodotnet:vs17.14from
AlexDelepine:patch-1

Conversation

@AlexDelepine
Copy link
Contributor

Context

We are experimenting with a mechanism to asynchronously generate important NGEN images immediately after VS setup in 17.14, and to do this are adjusting NGEN priorities of assemblies, so that the most important ones, based on JIT time, usage and user observable scenarios, are generated first. These changes are as a result of that analysis. If you have any questions on this, feel free to reach out to me or the VS Perf and Rel team.

Changes Made

Updated the following assemblies to have an ngen priority of 3:

  • MSBuild\Current\Bin\Microsoft.Extensions.Configuration.Abstractions.dll
  • MSBuild\Current\Bin\Microsoft.Extensions.Configuration.Binder.dll
  • MSBuild\Current\Bin\Microsoft.Extensions.Configuration.dll
  • MSBuild\Current\Bin\Microsoft.Extensions.DependencyInjection.Abstractions.dll
  • MSBuild\Current\Bin\Microsoft.Extensions.DependencyInjection.dll
  • MSBuild\Current\Bin\Microsoft.Extensions.Diagnostics.Abstractions.dll
  • MSBuild\Current\Bin\Microsoft.Extensions.Logging.Abstractions.dll
  • MSBuild\Current\Bin\Microsoft.Extensions.Logging.Configuration.dll
  • MSBuild\Current\Bin\Microsoft.Extensions.Logging.dll
  • MSBuild\Current\Bin\Microsoft.Extensions.Options.ConfigurationExtensions.dll
  • MSBuild\Current\Bin\Microsoft.Extensions.Options.dll
  • MSBuild\Current\Bin\Microsoft.Extensions.Primitives.dll
  • MSBuild\Current\Bin\Microsoft.VisualStudio.OpenTelemetry.ClientExtensions.dll
  • MSBuild\Current\Bin\Microsoft.VisualStudio.OpenTelemetry.Collector.dll
  • MSBuild\Current\Bin\Microsoft.VisualStudio.SolutionPersistence.dll
  • MSBuild\Current\Bin\Microsoft.VisualStudio.Utilities.Internal.dll
  • MSBuild\Current\Bin\OpenTelemetry.Api.dll
  • MSBuild\Current\Bin\OpenTelemetry.Api.ProviderBuilderExtensions.dll
  • MSBuild\Current\Bin\OpenTelemetry.dll
  • MSBuild\Current\Bin\System.Diagnostics.DiagnosticSource.dll
  • MSBuild\Current\Bin\System.Reflection.MetadataLoadContext.dll
  • MSBuild\Current\Bin\System.Resources.Extensions.dll

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we want this in 17.14, right? Let's retarget this PR.

@maridematte maridematte changed the base branch from main to vs17.14 March 31, 2025 14:18
@maridematte maridematte requested a review from a team as a code owner March 31, 2025 14:18
@YuliiaKovalova
Copy link
Member

@maridematte retargeting brought many unrelated changes
could you please create a separate PR for that?

Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased and force-pushed so this is ok to review/merge to 17.14 I think.

@YuliiaKovalova YuliiaKovalova enabled auto-merge (squash) March 31, 2025 16:50
@YuliiaKovalova YuliiaKovalova merged commit ae13ed0 into dotnet:vs17.14 Mar 31, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants