[vs17.14] Fix SdkResult Evalution when ProjectRootElement is null

[surayya-MS]

Fixes #11550

Context

This is a regression caused by changes in MSBuildSdkResolver that were introduced in dotnet/sdk#45364. Specifically by adding 2 new properties.
This results in hitting the path that was not hit before - handling properties and items of SdkResult:

msbuild/src/Build/Evaluation/Evaluator.cs

Lines 1867 to 1875 in 6aeb262

	if ((sdkResult.PropertiesToAdd?.Any() == true) ||
	(sdkResult.ItemsToAdd?.Any() == true))
	{
	projectList ??= new List<ProjectRootElement>();
	// Inserting at the beginning will mean that the properties or items from the SdkResult will be evaluated before
	// any projects from paths returned by the SDK Resolver.
	projectList.Insert(0, CreateProjectForSdkResult(sdkResult));
	}

When Project is created from XmlReader and not from ProjectRootElement, it results in null ProjectRootElement during Evaluation. Which results in internal exception like InternalErrorException: MSB0001: Internal MSBuild Error: .SdkResolver.1981936763.proj unexpectedly not a rooted path here:

msbuild/src/Build/Evaluation/Evaluator.cs

Line 1928 in 6aeb262

string projectPath = $"{_projectRootElement.FullPath}.SdkResolver.{propertiesAndItemsHash}.proj";

Above created project path is just .SdkResolver.1981936763.proj with no directory. Later exception is thrown here because of it:

msbuild/src/Build/Evaluation/ProjectRootElementCache.cs

Line 262 in 9e51a07

ErrorUtilities.VerifyThrowInternalRooted(projectFile);

or here if you use SimpleProjectRootElementCache:

msbuild/src/Build/Evaluation/SimpleProjectRootElementCache.cs

Line 43 in 9e51a07

ErrorUtilities.VerifyThrowInternalRooted(projectFile);

Changes Made

Changed the projet path that is created for SdkResult properties and items - if there is no ProjectRootElement then generate name like {Guid}.SdkResolver.{propertiesAndItemsHash}.proj in the current directory.

Testing

Added test. Tested manually as well

Notes

[tsvietOK]

Is there a workaround to use until this is released as part of the VS (build tools)?

[surayya-MS]

@tsvietOK you could try to copy the old MSBuildSdkResolver folder from Visual Studio 17.12 and put it in the newer Visual Studio. You can find it in your Visual Studio location (usually C:\Program Files\Microsoft Visual Studio\2022\Enterprise) {Visual Studio path}\MSBuild\Current\Bin\SdkResolvers\Microsoft.DotNet.MSBuildSdkResolver.

[tsvietOK]

@tsvietOK you could try to copy the old MSBuildSdkResolver folder from Visual Studio 17.12 and put it in the newer Visual Studio. You can find it in your Visual Studio location (usually C:\Program Files\Microsoft Visual Studio\2022\Enterprise) {Visual Studio path}\MSBuild\Current\Bin\SdkResolvers\Microsoft.DotNet.MSBuildSdkResolver.

Thank you, will try. Do you have any estimates of when this fix will be released?

[surayya-MS]

Thank you, will try. Do you have any estimates of when this fix will be released?

This fix will be in Visual Studio 17.14

[tsvietOK]

@tsvietOK you could try to copy the old MSBuildSdkResolver folder from Visual Studio 17.12 and put it in the newer Visual Studio. You can find it in your Visual Studio location (usually C:\Program Files\Microsoft Visual Studio\2022\Enterprise) {Visual Studio path}\MSBuild\Current\Bin\SdkResolvers\Microsoft.DotNet.MSBuildSdkResolver.

This suggestion helped, thanks!