Remove MSBuildRuntimeType conditions#11641
Merged
rainersigwald merged 3 commits intomainfrom Mar 28, 2025
Merged
Conversation
The VMR builds the msbuild repo with dotnet build. Therefore remove some of the MSBuildRuntimeType conditions which not be needed anymore.
Member
Author
|
OK I scoped this down so that the build succeeds ;) |
rainersigwald
approved these changes
Mar 27, 2025
mmitche
approved these changes
Mar 28, 2025
This was referenced Feb 9, 2026
Closed
Closed
Merged
Closed
Closed
This was referenced Feb 23, 2026
This was referenced Mar 2, 2026
Merged
This was referenced Mar 11, 2026
Closed
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VMR builds the msbuild repo with dotnet build. Therefore remove some of the MSBuildRuntimeType conditions which not be needed anymore.
Fixes dotnet/source-build#4981
Context
Changes Made
Testing
Notes