[vs17.12] Merge tag v17.12.36

[surayya-MS]

Fixes #

Context

Changes Made

Testing

Notes

[Copilot]

Pull Request Overview

This PR merges tag v17.12.36, bumps the version prefix, and refactors the file-name extraction in DownloadFile to take a URI instead of the full HTTP response.

• Changed TryGetFileName to accept a Uri and updated its call site.
• Removed fallback logic for Content-Disposition header when determining file names.
• Bumped <VersionPrefix> to 17.12.36 in eng/Versions.props.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/Tasks/DownloadFile.cs	Refactored TryGetFileName signature and logic; removed header-based filename fallback
eng/Versions.props	Updated <VersionPrefix> to 17.12.36

Comments suppressed due to low confidence (2)

src/Tasks/DownloadFile.cs:314

• [nitpick] Add unit tests for TryGetFileName to cover cases with a server-supplied Content-Disposition filename, user-specified DestinationFileName, and URI-only filenames.

private bool TryGetFileName(Uri requestUri, out string filename)

src/Tasks/DownloadFile.cs:326

• Removing the Content-Disposition fallback means server-provided filenames will no longer be used. Consider restoring response.Content.Headers.ContentDisposition?.FileName before falling back to the URI path.

: Path.GetFileName(requestUri.LocalPath);