Skip to content

Add the switch running OptProf tasks#12076

Merged
GangWang01 merged 3 commits intodotnet:vs17.11from
GangWang01:optprof-run-switch
Jul 2, 2025
Merged

Add the switch running OptProf tasks#12076
GangWang01 merged 3 commits intodotnet:vs17.11from
GangWang01:optprof-run-switch

Conversation

@GangWang01
Copy link
Member

In the case there isn't available VS manifest files from VSDrop, internal build is blocked by OptProf tasks. This needs another mode that opts out of all OptProf tasks. Then add the switch running OptProf tasks or not.

Copilot AI review requested due to automatic review settings June 27, 2025 06:40
@GangWang01 GangWang01 requested a review from a team as a code owner June 27, 2025 06:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new toggle to conditionally run or skip all OptProf tasks in the .vsts-dotnet pipeline.

  • Introduce EnableOptProf boolean parameter (default: true) to opt out of OptProf tasks when needed.
  • Update each OptProf-related task’s condition to include EnableOptProf.
Comments suppressed due to low confidence (2)

.vsts-dotnet.yml:19

  • [nitpick] Consider adding a brief comment above this parameter to explain its effect on the pipeline (e.g., which tasks are skipped when disabled) to improve clarity for consumers of the YAML.
- name: EnableOptProf

.vsts-dotnet.yml:160

  • [nitpick] Since this conditional is repeated for multiple tasks, you could extract and(succeeded(), ${{ parameters.EnableOptProf }}) into a reusable template expression or variable to reduce duplication and simplify future updates.
          condition: and(succeeded(), ${{ parameters.EnableOptProf }})

@GangWang01 GangWang01 requested a review from AR-May July 1, 2025 05:49
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
@GangWang01 GangWang01 merged commit e4f165e into dotnet:vs17.11 Jul 2, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants