Add the switch running OptProf tasks#12076
Merged
GangWang01 merged 3 commits intodotnet:vs17.11from Jul 2, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a new toggle to conditionally run or skip all OptProf tasks in the .vsts-dotnet pipeline.
- Introduce
EnableOptProfboolean parameter (default: true) to opt out of OptProf tasks when needed. - Update each OptProf-related task’s condition to include
EnableOptProf.
Comments suppressed due to low confidence (2)
.vsts-dotnet.yml:19
- [nitpick] Consider adding a brief comment above this parameter to explain its effect on the pipeline (e.g., which tasks are skipped when disabled) to improve clarity for consumers of the YAML.
- name: EnableOptProf
.vsts-dotnet.yml:160
- [nitpick] Since this conditional is repeated for multiple tasks, you could extract
and(succeeded(), ${{ parameters.EnableOptProf }})into a reusable template expression or variable to reduce duplication and simplify future updates.
condition: and(succeeded(), ${{ parameters.EnableOptProf }})
YuliiaKovalova
approved these changes
Jun 27, 2025
rainersigwald
approved these changes
Jul 1, 2025
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
This was referenced Feb 4, 2026
Closed
This was referenced Feb 12, 2026
Closed
Merged
Closed
Closed
This was referenced Feb 22, 2026
Open
This was referenced Mar 2, 2026
This was referenced Mar 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case there isn't available VS manifest files from VSDrop, internal build is blocked by OptProf tasks. This needs another mode that opts out of all OptProf tasks. Then add the switch running OptProf tasks or not.