Add comment for updating MicrosoftCodeAnalysisCollectionsVersion#12181
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds clarification comments and separate version properties for Roslyn source-only packages to ensure they are updated correctly in source-build reference packages.
- Moves
MicrosoftCodeAnalysisCollectionsVersioninto a dedicated property group with explanation. - Introduces
MicrosoftCodeAnalysisContractsVersionandMicrosoftCodeAnalysisPooledObjectsVersionproperties. - Updates
eng/Packages.propsto reference the new version properties for Contracts and PooledObjects.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/Versions.props | Added comment and new property group for manual updates; defined version props for Collections, Contracts, and PooledObjects. |
| eng/Packages.props | Updated package version references to use the newly added properties for Contracts and PooledObjects. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rainersigwald
approved these changes
Jul 16, 2025
YuliiaKovalova
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12161 broke in the VMR dependency flow PR dotnet/dotnet#1490 because this version isn't in source-build-reference-packages.
Add a comment so this is clearer when updating next time.