Add support for schema validation in dotnet msbuild.#12230
Closed
teo-tsirpanis wants to merge 8 commits intodotnet:mainfrom
Closed
Add support for schema validation in dotnet msbuild.#12230teo-tsirpanis wants to merge 8 commits intodotnet:mainfrom
dotnet msbuild.#12230teo-tsirpanis wants to merge 8 commits intodotnet:mainfrom
Conversation
Fixes at least one failing test. Type checking in tests was also enhanced to better catch these kinds of errors.
teo-tsirpanis
force-pushed
the
validate-netcore
branch
from
b6cb337 to
ec46ffe
Compare
Contributor
|
This pull request has been automatically closed because it has been open for more than 180 days with no recent activity. If you believe this work is still relevant, please feel free to reopen or create a new pull request. Thank you for your contribution!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12229
Note
Depends on #12231.
Context
The
-validateCLI option was restricted to .NET Framework editions of MSBuild, but the underlying APIs are available on all currently supported frameworks. This PR stops excluding the code in question to only .NET Framework, which adds this CLI options todotnet msbuild.Changes Made
The
FEATURE_XML_SCHEMA_VALIDATIONdirective was removed, and the code it was guarding is now compiled on all frameworks.Testing
Existing tests enabled to run on all frameworks.
Notes