Enlighten public versions of intrinsic tasks.#13267
Draft
AR-May wants to merge 3 commits intodotnet:mainfrom
Draft
Enlighten public versions of intrinsic tasks.#13267AR-May wants to merge 3 commits intodotnet:mainfrom
AR-May wants to merge 3 commits intodotnet:mainfrom
Conversation
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JanProvaznik
requested changes
Feb 23, 2026
| if (projects[i] != null) | ||
| { | ||
| // Retrieve projectDirectory only the first time. It never changes anyway. | ||
| string projectPath = FileUtilities.AttemptToShortenPath(projects[i].ItemSpec); |
danmoseley
reviewed
Mar 3, 2026
| [RunInMTA] | ||
| public class MSBuild : TaskExtension | ||
| [MSBuildMultiThreadableTask] | ||
| public class MSBuild : TaskExtension, IMultiThreadableTask |
Member
There was a problem hiding this comment.
Multi is not a word, per guidelines it should be capitalized as IMultithreadableTask I believe
Member
Author
There was a problem hiding this comment.
Good point, we missed it on the API review. We, unfortunately, already shipped this version.
This was referenced Apr 19, 2026
This was referenced Apr 20, 2026
Closed
This was referenced Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We have enlightened the internal versions of CallTarget and MSbuild tasks, but not the public ones.
Changes Made
Enlighten the public versions of intrinsic tasks.
Testing
Unit tests