Skip to content

Do not share assemblies of task dependencies if not running on MSBuild.exe. #13285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teo-tsirpanis wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Do not share assemblies of task dependencies if not running on MSBuild.exe. #13285

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af73d82
Do not share assemblies of task dependencies if not running on `MSBui…
teo-tsirpanis Feb 24, 2026
0497f54
Address Copilot feedback.
teo-tsirpanis Feb 24, 2026
95e56e4
Update comments.
teo-tsirpanis Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Shared/MSBuildLoadContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,15 @@ public MSBuildLoadContext(string assemblyPath)
// If the Assembly is provided via a file path, the following rules are used to load the assembly:
// - the assembly from the user specified path is loaded, if it exists, into the custom ALC, or
// - if the simple name of the assembly exists in the same folder as msbuild.exe, then that assembly gets loaded
// into the default ALC (so it's shared with other uses).
// into the default ALC (so it's shared with other uses), or into the custom ALC if we are not running on
// MSBuild.exe (because it might interfere with the app's own dependencies).
var assemblyNameInExecutableDirectory = Path.Combine(BuildEnvironmentHelper.Instance.CurrentMSBuildToolsDirectory,
$"{assemblyName.Name}.dll");

if (FileSystems.Default.FileExists(assemblyNameInExecutableDirectory))
{
return AssemblyLoadContext.Default.LoadFromAssemblyPath(assemblyNameInExecutableDirectory);
AssemblyLoadContext targetAlc = BuildEnvironmentHelper.Instance.RunningInMSBuildExe ? Default : this;
return targetAlc.LoadFromAssemblyPath(assemblyNameInExecutableDirectory);
}

return null;
Expand Down
Loading