Stabilize ToolTaskThatTimeoutAndRetry test#13489
Merged
rainersigwald merged 5 commits intomainfrom Apr 14, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Make the retry test assert the timeout scenario explicitly, log per-attempt diagnostics, and keep the follow-up executions deterministic across retries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR stabilizes the ToolTaskThatTimeoutAndRetry unit test in Utilities.UnitTests by removing timing-sensitive shell indirection and making the timeout/retry expectations explicit and easier to diagnose when failures occur in CI.
Changes:
- Replace the shell-based sleep invocation with direct OS tools (
sleepon Unix,ping.exeon Windows) and document thetimeout.exelimitation underToolTask. - Refactor the theory inputs and assertions to explicitly model “first attempt times out, subsequent attempts succeed”.
- Add per-attempt diagnostic output (including exit code) and clear the mock engine log between attempts to keep logs readable.
rainersigwald
commented
Apr 6, 2026
…onds Agent-Logs-Url: https://github.com/dotnet/msbuild/sessions/766be90d-7dd3-492f-bb8d-4bf35765da5b Co-authored-by: rainersigwald <3347530+rainersigwald@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/msbuild/sessions/81558234-b82a-4e91-8cbe-75dc53221865 Co-authored-by: rainersigwald <3347530+rainersigwald@users.noreply.github.com>
JanProvaznik
approved these changes
Apr 10, 2026
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fastDelayMillisecondsfromNativeMethodsShared.IsWindows ? 1_000 : 100to a flat100