Skip to content

Final branding for 18.7 release#13658

Merged
JanProvaznik merged 1 commit intodotnet:vs18.7from
SimaTian:tomasbartonek/final-branding-18.7
Apr 30, 2026
Merged

Final branding for 18.7 release#13658
JanProvaznik merged 1 commit intodotnet:vs18.7from
SimaTian:tomasbartonek/final-branding-18.7

Conversation

@SimaTian
Copy link
Copy Markdown
Member

Phase 4 of the 18.7 release checklist: final branding for the 18.7.0 release.

Changes (generated by scripts/Stabilize-Release.ps1)

  • Add <DotNetFinalVersionKind>release</DotNetFinalVersionKind> on the VersionPrefix line (kept inline to create a conflict in forward-flow per release docs)
  • Change PreReleaseVersionLabel from preview to servicing

Notes

⚠️ Time-sensitive: VS snaps mainrel/insiders on 2026-05-01. Final-branded bits need to be in VS main before the snap.

Tracks #13639.

Stabilize the vs18.7 branch for the 18.7.0 release:
- Add <DotNetFinalVersionKind>release</DotNetFinalVersionKind> on the VersionPrefix line
- Change PreReleaseVersionLabel from 'preview' to 'servicing'

Generated by scripts/Stabilize-Release.ps1.

Tracking: dotnet#13639

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 30, 2026 09:47
@SimaTian SimaTian requested a review from a team as a code owner April 30, 2026 09:47
@SimaTian SimaTian mentioned this pull request Apr 30, 2026
53 tasks
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs the final branding step for the vs18.7 release branch, aligning eng/Versions.props with the repo’s documented release process for producing final-branded (non-preview) builds that insert into Visual Studio.

Changes:

  • Adds DotNetFinalVersionKind=release inline with VersionPrefix (intentionally to force a forward-flow merge conflict per release guidance).
  • Switches PreReleaseVersionLabel from preview to servicing.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release Branding Review — eng/Versions.props

Verdict: Looks correct. Standard final-branding change following the established pattern.

Review Summary

Dimension Status Notes
Correctness DotNetFinalVersionKind=release is the correct value for final branding
Convention Matches pattern from prior releases (18.6) and Stabilize-Release.ps1 automation
Forward-flow strategy Inline placement on VersionPrefix line is intentional — forces merge conflict on forward-flow
PreReleaseVersionLabel previewservicing is the expected transition for release branches
Breaking change risk ✅ None Pure versioning metadata; no behavioral change to the engine
Downstream impact ✅ Expected Packages will ship as stable (no prerelease suffix). This is the intended effect.

No issues found.

Note

🔒 Integrity filter blocked 1 item

The following item were blocked because they don't meet the GitHub integrity level.

  • #13658 pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by Expert Code Review (on open) for issue #13658 · ● 1.3M

Comment thread eng/Versions.props
Comment thread eng/Versions.props
@JanProvaznik JanProvaznik merged commit 6ed5e9a into dotnet:vs18.7 Apr 30, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants