Final branding for 18.7 release#13658
Merged
JanProvaznik merged 1 commit intodotnet:vs18.7from Apr 30, 2026
Merged
Conversation
Stabilize the vs18.7 branch for the 18.7.0 release: - Add <DotNetFinalVersionKind>release</DotNetFinalVersionKind> on the VersionPrefix line - Change PreReleaseVersionLabel from 'preview' to 'servicing' Generated by scripts/Stabilize-Release.ps1. Tracking: dotnet#13639 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
53 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs the final branding step for the vs18.7 release branch, aligning eng/Versions.props with the repo’s documented release process for producing final-branded (non-preview) builds that insert into Visual Studio.
Changes:
- Adds
DotNetFinalVersionKind=releaseinline withVersionPrefix(intentionally to force a forward-flow merge conflict per release guidance). - Switches
PreReleaseVersionLabelfrompreviewtoservicing.
Contributor
There was a problem hiding this comment.
Release Branding Review — eng/Versions.props
Verdict: Looks correct. Standard final-branding change following the established pattern.
Review Summary
| Dimension | Status | Notes |
|---|---|---|
| Correctness | ✅ | DotNetFinalVersionKind=release is the correct value for final branding |
| Convention | ✅ | Matches pattern from prior releases (18.6) and Stabilize-Release.ps1 automation |
| Forward-flow strategy | ✅ | Inline placement on VersionPrefix line is intentional — forces merge conflict on forward-flow |
PreReleaseVersionLabel |
✅ | preview → servicing is the expected transition for release branches |
| Breaking change risk | ✅ None | Pure versioning metadata; no behavioral change to the engine |
| Downstream impact | ✅ Expected | Packages will ship as stable (no prerelease suffix). This is the intended effect. |
No issues found.
Note
🔒 Integrity filter blocked 1 item
The following item were blocked because they don't meet the GitHub integrity level.
- #13658
pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
To allow these resources, lower min-integrity in your GitHub frontmatter:
tools:
github:
min-integrity: approved # merged | approved | unapproved | noneGenerated by Expert Code Review (on open) for issue #13658 · ● 1.3M
JanProvaznik
approved these changes
Apr 30, 2026
AR-May
approved these changes
Apr 30, 2026
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of the 18.7 release checklist: final branding for the 18.7.0 release.
Changes (generated by
scripts/Stabilize-Release.ps1)<DotNetFinalVersionKind>release</DotNetFinalVersionKind>on theVersionPrefixline (kept inline to create a conflict in forward-flow per release docs)PreReleaseVersionLabelfrompreviewtoservicingNotes
PublicAPI.Unshipped.txtentries onvs18.7.main→rel/insiderson 2026-05-01. Final-branded bits need to be in VSmainbefore the snap.Tracks #13639.