Add RoslynCodeTaskFactory and DownloadFile samples#3313
Add RoslynCodeTaskFactory and DownloadFile samples#3313jeffkl wants to merge 3 commits intodotnet:masterfrom
Conversation
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
I think I'd rather see all of this in the Docs repo rather than here. . . Do you think it needs to be here?
| @@ -0,0 +1,18 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
There was a problem hiding this comment.
I'd say to not specify the xml header or the namespace in samples, since they're no longer needed.
| <Output TaskParameter="DownloadedFile" ItemName="Content" /> | ||
| </DownloadFile> | ||
|
|
||
| <!-- Include the f--> |
| <!-- Download a file --> | ||
| <DownloadFile | ||
| SourceUrl="https://raw.githubusercontent.com/Microsoft/msbuild/master/LICENSE" | ||
| DestinationFolder="$(MSBuildProjectDirectory)"> |
There was a problem hiding this comment.
Can you specify a path or something so this can be named DownloadedFile instead of LICENSE? I found the .gitignore confusing.
I wanted more test coverage to ensure that we don't break at least RoslynCodeTaskFactory. |
👍 also it is bit strange when we search and find zero usages of built-in task in the repo. |
2 participants
DownloadFile task was added by #3297
RoslynCodeTaskFactory was added by #3175
Delete empty
src/Samples/Directory.Build.targets