Always throttle log message handling#3579
Closed
rainersigwald wants to merge 1 commit into
Closed
Conversation
Fixes dotnet#3577 by applying the throttling policy to the processing of all logging events, not just those from other nodes. While this will slow the build down, it will keep the memory usage of log events in the to-be-processed queue bounded, preventing the OOM reported in the bug.
Member
Author
|
I don't know why yet, but this is incomplete. So far, it looks like the queue fills and then we hit a deadlock of some sort. |
Member
Author
|
This is sufficiently broken by #3577 (comment) that I'm just going to close it and rethink. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3577 by applying the throttling policy to the processing of all
logging events, not just those from other nodes.
While this will slow the build down, it will keep the memory usage of
log events in the to-be-processed queue bounded, preventing the OOM
reported in the bug.