Typo fixes in *FileHash tasks#4104
Merged
rainersigwald merged 2 commits intodotnet:vs16.0from Jan 31, 2019
Merged
Conversation
rainersigwald
added
the
Area: Tasks
| var hash = ComputeHash(Algorithm, file.ItemSpec); | ||
| file.SetMetadata("FileHashAlgorithm", Algorithm); | ||
|
|
||
| // This typo shipped in 15.8 and 15.9; preserve it for backward compat. |
Contributor
There was a problem hiding this comment.
It seems unlikely anyone was actually using this given there were other issues like #3999. I'm okay if we just fix the name.
Member
Author
There was a problem hiding this comment.
I dithered on this and decided to propose the conservative option, but I tend to agree. @livarcocc do you have a preference? It'd technically be a 15.8->16.0 breaking change, but not one that we expect anyone to notice.
natemcmaster
approved these changes
Jan 28, 2019
livarcocc
approved these changes
Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @natemcmaster