[master] Update dependencies from dotnet/arcade#4251
Merged
dotnet-maestro[bot] merged 4 commits intomasterfrom Mar 20, 2019
Merged
[master] Update dependencies from dotnet/arcade#4251dotnet-maestro[bot] merged 4 commits intomasterfrom
dotnet-maestro[bot] merged 4 commits intomasterfrom
Conversation
…317.10 - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19167.10
Contributor
Author
Auto-Merge StatusThis pull request has not been merged because Maestro++ is waiting on the following merge policies.
|
LICENSE
Outdated
Member
There was a problem hiding this comment.
@livarcocc can you make sure this license change is ok? New Arcade requires it.
rainersigwald
force-pushed
the
darc-master-51766e52-efa0-4e52-af3c-66eb4ade4943
branch
from
71f0e25 to
c22da67
Compare
Member
|
I give up: now CI builds are failing because they run using MSBuild 15 and so can't use an SDK with a new enough NuGet to pack the new Arcade defaults. Do we have to switch to a 2019 pool @tmat? |
Contributor
Author
Auto-Merge StatusThis pull request has been merged because the following merge policies have succeeded.
|
rainersigwald
force-pushed
the
darc-master-51766e52-efa0-4e52-af3c-66eb4ade4943
branch
2 times, most recently
from
e114c87 to
c089ed3
Compare
This is required by new enforcement of LicenseExpression, which isn't supported by versions of NuGet before 4.9, included with MSBuilds before 15.9.
rainersigwald
force-pushed
the
darc-master-51766e52-efa0-4e52-af3c-66eb4ade4943
branch
from
c089ed3 to
171f971
Compare
livarcocc
approved these changes
Mar 20, 2019
dotnet-maestro
bot
deleted the
darc-master-51766e52-efa0-4e52-af3c-66eb4ade4943
branch
tmat
reviewed
Mar 20, 2019
| <owners>Microsoft</owners> | ||
| <requireLicenseAcceptance>true</requireLicenseAcceptance> | ||
| <licenseUrl>$licenseUrl$</licenseUrl> | ||
| <license type="expression">$licenseExpression$</license> |
Member
There was a problem hiding this comment.
BTW: repository metadata element is missing here.
You can clean this up and make sure all metadata is set by using $CommonMetadataElements$ variable like so:
This variable is set by Arcade based on standard project properties here: https://github.com/dotnet/arcade/blob/master/src/Microsoft.DotNet.Arcade.Sdk/tools/Workarounds.targets#L121
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/dotnet/arcade