Implement feature that allows tasks to get the global properties#4939
Merged
rainersigwald merged 5 commits intodotnet:masterfrom Nov 25, 2019
Merged
Implement feature that allows tasks to get the global properties#4939rainersigwald merged 5 commits intodotnet:masterfrom
rainersigwald merged 5 commits intodotnet:masterfrom
Conversation
jeffkl
commented
Nov 21, 2019
Member
rainersigwald
left a comment
There was a problem hiding this comment.
Should accessing this emit a log event? I kinda want it to to minimize the "invisible input" problem.
Contributor
Author
|
It seems a little weird to log a message but it does sort of make sense. I had coded up something but I couldn't decide on the message as I'm not sure what it should say? If there's a message you like, I'll gladly put it in there. |
Contributor
Author
|
/cc @AndyGerlicher |
Contributor
|
I would say no on logging? If we want that maybe in the style of #4461 which was reverted. Logging the reads seems like a natural extension of that. |
Contributor
Author
|
@AndyGerlicher I agree, let's add logging events later as part of the bigger effort to capture things that effect the build, what do you think @rainersigwald? |
Contributor
Author
|
@rainersigwald gentle ping... |
rainersigwald
approved these changes
Nov 25, 2019
Forgind
approved these changes
Nov 25, 2019
Contributor
Author
|
Thanks all! |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an implementation of #4925 which allows tasks to get the current project's global properties.
I added an
IBuildEngine6and plumbed the global properties to the appropriate task hosts.