Darc for bootstrap dependencies#5909
Merged
rainersigwald merged 3 commits intodotnet:masterfrom Nov 30, 2020
Merged
Conversation
Enable more-automated NuGet reference updating by adding a Darc dependency. Match the current version; update to come later.
Enable more-automated Roslyn reference updating by adding a Darc dependency. This dependency isn't used to _build_, only to assemble our test folders, so a stale reference isn't super tragic. But should be fixed anyway. Match the current version; update to come later.
rainersigwald
added
the
Area: Our Own Build
Forgind
approved these changes
Nov 25, 2020
Contributor
Forgind
left a comment
Forgind
left a comment
There was a problem hiding this comment.
I don't know that I can really review this properly. I haven't looked into why tests were failing for my version update PR—is this the fix?
Member
Author
|
I also confirmed offline that this won't cause coherency problems because they are toolset dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the darc metadata for our dependencies on NuGet and Roslyn. These are toolset dependencies because we use them to construct our bootstrap folder/test environments, but we don't have product code dependencies here--
RoslynCodeTaskFactoryrequires Roslyn but doesn't depend on it in the normal way to break cycles/allow floating versions.This PR changes versions only for the Roslyn build task used for unit tests, making it match the toolset version used to make the bootstrap.