Skip to content

Optimization neglected to include condition#5927

Merged
Forgind merged 2 commits into
dotnet:masterfrom
Forgind:fix-skipped-condition
Dec 3, 2020
Merged

Optimization neglected to include condition#5927
Forgind merged 2 commits into
dotnet:masterfrom
Forgind:fix-skipped-condition

Conversation

@Forgind
Copy link
Copy Markdown
Contributor

@Forgind Forgind commented Dec 2, 2020

Fixes #5766

Introduced by #5350

@rainersigwald
Copy link
Copy Markdown
Member

Looks very plausible as the solution. 🤦🏻‍♂️

@Forgind
Copy link
Copy Markdown
Contributor Author

Forgind commented Dec 2, 2020

Tested it, and everything checked out. Upgrading to PR.

@Forgind Forgind marked this pull request as ready for review December 2, 2020 19:21
Copy link
Copy Markdown
Member

@benvillalobos benvillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Forgind Forgind merged commit cd29721 into dotnet:master Dec 3, 2020
@Forgind Forgind deleted the fix-skipped-condition branch December 3, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conditioned ItemGroup executes Remove sometimes when it shouldn't

3 participants