Have ProjectInSolution.AbsolutePath return a normalized path#5950
Merged
rainersigwald merged 2 commits intodotnet:masterfrom Dec 16, 2020
Merged
Have ProjectInSolution.AbsolutePath return a normalized path#5950rainersigwald merged 2 commits intodotnet:masterfrom
rainersigwald merged 2 commits intodotnet:masterfrom
Conversation
jeffkl
force-pushed
the
fix-projectinsolution-absolutepath
branch
from
46ffea4 to
74b8fc6
Compare
jeffkl
changed the title
jeffkl
force-pushed
the
fix-projectinsolution-absolutepath
branch
from
85d8ddb to
b4d19f6
Compare
Forgind
reviewed
Dec 14, 2020
jeffkl
force-pushed
the
fix-projectinsolution-absolutepath
branch
from
b4d19f6 to
3eed692
Compare
Forgind
approved these changes
Dec 14, 2020
rainersigwald
approved these changes
Dec 15, 2020
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
Ideally I'd like it interactive rebased to have a commit for the shouldly migration and a separate commit for the actual change.
jeffkl
force-pushed
the
fix-projectinsolution-absolutepath
branch
from
c1dbf39 to
fc8e5cf
Compare
jeffkl
added a commit
to jeffkl/msbuild
that referenced
this pull request
Mar 10, 2021
dotnet#5950 introduced a call to `Path.GetFullPath()` to get a path that is normalized. However, in some cases Visual Studio stores unsupported paths which will cause `Path.GetFullPath()` to throw. `Path.GetFullPath()` can also throw a `PathTooLongException` which is now handled. Fixes dotnet#6236
benvillalobos
pushed a commit
to benvillalobos/msbuild
that referenced
this pull request
Mar 16, 2021
dotnet#5950 introduced a call to `Path.GetFullPath()` to get a path that is normalized. However, in some cases Visual Studio stores unsupported paths which will cause `Path.GetFullPath()` to throw. `Path.GetFullPath()` can also throw a `PathTooLongException` which is now handled. Fixes dotnet#6236
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates
ProjectInSolution.AbsolutePathto return a normalized path. At the moment it simply returns the result of aPath.Combine()which leaves..\path segments in place and does not contain OS-specific path separators.Fixes #5949 and NuGet/Home#10307