Skip to content

Switch eng/common to linguist-vendored#6022

Merged
rainersigwald merged 2 commits intodotnet:masterfrom
rainersigwald:linguist-vendored-for-eng-common
Jan 12, 2021
Merged

Switch eng/common to linguist-vendored#6022
rainersigwald merged 2 commits intodotnet:masterfrom
rainersigwald:linguist-vendored-for-eng-common

Conversation

@rainersigwald
Copy link
Copy Markdown
Member

This is a more accurate description of what's going on here; the code canonically lives in dotnet/arcade and so is vendored here.

This is a more accurate description of what's going on here;
the code canonically lives in dotnet/arcade and so is vendored
here.
@rainersigwald
Copy link
Copy Markdown
Member Author

@benvillalobos I'd like to merge this ASAP because it will make reviewing #5836 easier :)

@benvillalobos
Copy link
Copy Markdown
Member

@rainersigwald this modifies PR reviews as well? I read the docs as it applying more to the stats on our repo page for languages.

@rainersigwald
Copy link
Copy Markdown
Member Author

this modifies PR reviews as well? I read the docs as it applying more to the stats on our repo page for languages.

That's . . . a really good question. I read it that way but maybe not? Checking now.

@rainersigwald
Copy link
Copy Markdown
Member Author

Looks like we need both; see https://github.com/rainersigwald/msbuild/pull/4/files

@benvillalobos
Copy link
Copy Markdown
Member

LGTM. This is a cool feature, effectively hiding all irrelevant changes. I kinda wish it would highlight that better, IIRC the message Some generated files are not rendered by default. Learn more. looks similar to the message about how some diffs are too big . So it could easily be mistaken.

@rainersigwald rainersigwald merged commit 7b18884 into dotnet:master Jan 12, 2021
@benvillalobos
Copy link
Copy Markdown
Member

@rainersigwald should we consider adding linguist-generated to everything under ref/? Had this idea when looking over #5936. If so, should be considered "low priority quality of life change"

@benvillalobos
Copy link
Copy Markdown
Member

While we're at it, src/Build/Resources/xlf to auto-hide generated resources would be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants