Skip to content

Remove more unnecessary NuGet package references.#6036

Merged
Forgind merged 5 commits intodotnet:masterfrom
teo-tsirpanis:nuget-cleanup
Feb 9, 2021
Merged

Remove more unnecessary NuGet package references.#6036
Forgind merged 5 commits intodotnet:masterfrom
teo-tsirpanis:nuget-cleanup

Conversation

@teo-tsirpanis
Copy link
Copy Markdown
Contributor

@teo-tsirpanis teo-tsirpanis commented Jan 14, 2021

A continuation of #5242, this PR removes more NuGet packages, some of which were added later.

I have seen that some packages like System.Collections.Immutable were updated to version 5.0.0. Can I do the same for the other system packages as well?

@rainersigwald
Copy link
Copy Markdown
Member

rainersigwald commented Jan 14, 2021

I have seen that some packages like System.Collections.Immutable were updated to version 5.0.0. Can I do the same for the other system packages as well?

Not trivially, because we often have to coordinate with other repos and Visual Studio itself. I started taking a crack at this in #5910 but got bogged down and probably won't finish before I head out on parental leave.

@teo-tsirpanis
Copy link
Copy Markdown
Contributor Author

teo-tsirpanis commented Jan 14, 2021

I head out on parental leave

Congratulations!! 🥳👶🏻

benvillalobos
benvillalobos approved these changes Jan 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@benvillalobos benvillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

benvillalobos
benvillalobos reviewed Jan 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@benvillalobos benvillalobos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from the PR review meeting: Any PackageReference items that were removed should also remove the equivalent PackageReference in the eng\Packages.props file.

Comment thread src/Build.UnitTests/Microsoft.Build.Engine.UnitTests.csproj
Comment thread src/Tasks.UnitTests/Microsoft.Build.Tasks.UnitTests.csproj
Comment thread src/Tasks/Microsoft.Build.Tasks.csproj
Comment thread src/Tasks/Microsoft.Build.Tasks.csproj
Comment thread src/Utilities.UnitTests/Microsoft.Build.Utilities.UnitTests.csproj
@teo-tsirpanis
Copy link
Copy Markdown
Contributor Author

teo-tsirpanis commented Jan 15, 2021

Done @benvillalobos. I also cleaned-up all unused Packages.props entries.

Forgind
Forgind approved these changes Jan 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Our master branch is temporarily closed to new commits, but we'll merge this soon. Thanks for this!

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jan 21, 2021
Forgind
Forgind reviewed Feb 8, 2021
View reviewed changes
Comment thread eng/Packages.props
@Forgind Forgind merged commit 9657f12 into dotnet:master Feb 9, 2021
@Forgind
Copy link
Copy Markdown
Contributor

Forgind commented Feb 9, 2021

Thanks @teo-tsirpanis!

@teo-tsirpanis teo-tsirpanis deleted the nuget-cleanup branch February 9, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@benvillalobos benvillalobos benvillalobos approved these changes

@Forgind Forgind Forgind approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@teo-tsirpanis @rainersigwald @Forgind @benvillalobos