Revert 16.10 branding changes in app.config to match Microsoft.Build.CPPTasks.Common#6087
Revert 16.10 branding changes in app.config to match Microsoft.Build.CPPTasks.Common#6087ladipro wants to merge 1 commit intodotnet:masterfrom
Conversation
|
I'm a little confused—I thought the idea was that our master branch is 16.10 now and should not be inserted into vs main right now, so the fact that VS main is misinterpreting it doesn't matter; we just shouldn't insert? |
|
It looks like we may not even want to merge this. @marcpopMSFT suggested that when VS snaps to 16.10, this error may go away. I'm not sure on the details of that though. |
|
My understanding is that our prior insertion into VS main failed because our branding was 16.10 and VS main was still 16.9. If we wait until next week and then switch to 16.10, my expectation is that we will no longer be blocked by this specific issue. |
|
I think you're right, this will likely resolve itself once Main snaps to 16.10. I erroneously assumed that |
Context
The recent branding changes made us expect 16.10 version of
Microsoft.Build.CPPTasks.Commonbut the current VS Main is still building this assembly as 16.9.Changes Made
Reverted branding changes made to
app.config, both flavors.Testing
Verified that latest Visual Studio Main with this change can successfully build C++ projects.