Skip to content

Revert 16.10 branding changes in app.config to match Microsoft.Build.CPPTasks.Common#6087

Closed
ladipro wants to merge 1 commit intodotnet:masterfrom
ladipro:revert-cpptask-version-bump
Closed

Revert 16.10 branding changes in app.config to match Microsoft.Build.CPPTasks.Common#6087
ladipro wants to merge 1 commit intodotnet:masterfrom
ladipro:revert-cpptask-version-bump

Conversation

@ladipro
Copy link
Copy Markdown
Member

@ladipro ladipro commented Jan 26, 2021

Context

The recent branding changes made us expect 16.10 version of Microsoft.Build.CPPTasks.Common but the current VS Main is still building this assembly as 16.9.

Changes Made

Reverted branding changes made to app.config, both flavors.

Testing

Verified that latest Visual Studio Main with this change can successfully build C++ projects.

@Forgind
Copy link
Copy Markdown
Contributor

Forgind commented Jan 26, 2021

I'm a little confused—I thought the idea was that our master branch is 16.10 now and should not be inserted into vs main right now, so the fact that VS main is misinterpreting it doesn't matter; we just shouldn't insert?

@benvillalobos
Copy link
Copy Markdown
Member

It looks like we may not even want to merge this. @marcpopMSFT suggested that when VS snaps to 16.10, this error may go away. I'm not sure on the details of that though.

@marcpopMSFT
Copy link
Copy Markdown
Member

My understanding is that our prior insertion into VS main failed because our branding was 16.10 and VS main was still 16.9. If we wait until next week and then switch to 16.10, my expectation is that we will no longer be blocked by this specific issue.

@ladipro
Copy link
Copy Markdown
Member Author

ladipro commented Jan 27, 2021

I think you're right, this will likely resolve itself once Main snaps to 16.10. I erroneously assumed that Microsoft.Build.CPPTasks.Common is inserted into VS and so the C++ team must first have a successful insertion after updating their branding before we can go in. That doesn't seem to be true, Microsoft.Build.CPPTasks.Common is built in the VS repo and we were simply too early.

@ladipro ladipro closed this Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants