Use powershell sleep in unit tests

[KirillOsenkov]

Fixes #6265

The sleep NuGet package (https://www.nuget.org/packages/sleep) was uploaded to the dotnet-public feed for us by Matt Mitchell.

The source is here: https://github.com/KirillOsenkov/Misc/tree/main/Sleep

This makes our build less dependent on the machine state. Currently on Windows it may pick up C:\Program Files\Git\usr\bin\sleep.exe if it is installed and on the PATH (this is what happens on CI). But for users that don't have it on the PATH the test fails. Let's make sure our build is hermetic and self-sufficient.

Also renaming a method parameter to add clarity.

[Forgind]

Thanks! I appreciate this.

[ladipro]

This looks great although I wonder if the extra dependency is worth it if we can simply make the test run cmd /c timeout 600 on Windows.

[KirillOsenkov]

lol NOW you show up!

I had no idea this exists:

C:\>where timeout
C:\Windows\System32\timeout.exe

C:\>timeout /?

TIMEOUT [/T] timeout [/NOBREAK]

Description:
    This utility accepts a timeout parameter to wait for the specified
    time period (in seconds) or until any key is pressed. It also
    accepts a parameter to ignore the key press.

Parameter List:
    /T        timeout       Specifies the number of seconds to wait.
                            Valid range is -1 to 99999 seconds.

    /NOBREAK                Ignore key presses and wait specified time.

    /?                      Displays this help message.

NOTE: A timeout value of -1 means to wait indefinitely for a key press.

Examples:
    TIMEOUT /?
    TIMEOUT /T 10
    TIMEOUT /T 300 /NOBREAK
    TIMEOUT /T -1

Sigh I'm just too lazy to redo it. Maybe I should.

[KirillOsenkov]

@ladipro I've switched to timeout.exe which is in C:\Windows\system32, thanks for the tip!

[KirillOsenkov]

Unfortunately when I tried to use timeout.exe on CI it failed with exit code 1. I have no idea why :-/

I force pushed my original approach with a custom NuGet package which seems to work both locally and on CI.

If anyone wants to investigate the timeout approach, you can use the commit b9957ef

[ladipro]

@KirillOsenkov apologies for randomizing you. No idea why timeout wouldn't work in CI and not worth spending time on it for sure. Thank you!

[KirillOsenkov]

No problem at all, I did learn something. I'm guessing timeout won't work when there is no active user session logged on (just a guess though). Other than that I have no idea why it wouldn't work.

[rainersigwald]

We've solved this in the past with no external dependencies. Let me see how that works and try to use it here.

[rainersigwald]

There it is:

msbuild/src/Shared/UnitTests/ObjectModelHelpers.cs

Lines 1843 to 1852 in 369631b

	/// <summary>
	/// Gets a command template that can be used by an Exec task to sleep for the specified amount of time. The string has to be formatted with the number of seconds to sleep
	/// </summary>
	internal static string GetSleepCommandTemplate()
	{
	return
	NativeMethodsShared.IsWindows
	? "@powershell -NoLogo -NoProfile -command &quot;Start-Sleep -Milliseconds {0}&quot; &gt;nul"
	: "sleep {0}";
	}

[KirillOsenkov]

Nice, thanks for fixing this for me.