Fix TasksCanAddRecursiveDirBuiltInMetadata()#6337
Merged
benvillalobos merged 4 commits intomainfrom Apr 22, 2021
Merged
Conversation
Don't use Program Files\Reference Assemblies as that might not exist for 64-bit. Pass ITestOutputLogger to MockLogger to get the full log in case of failure. Search for a log substring that will only be there in case of success. Even successful logs can contain [] when the file is at the root of the directory so RecursiveDir will be empty.
Forgind
approved these changes
Apr 12, 2021
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
cdmihai
approved these changes
Apr 15, 2021
rainersigwald
approved these changes
Apr 15, 2021
Forgind
added
the
merge-when-branch-open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't use Program Files\Reference Assemblies as that might not exist for 64-bit.
Pass ITestOutputLogger to MockLogger to get the full log in case of failure.
Search for a log substring that will only be there in case of success. Even successful logs can contain [] when the file is at the root of the directory so RecursiveDir will be empty.
Fixes #6267