Bring back ProjectStarted.GlobalProperties#6342
Merged
Conversation
Some loggers depended on ProjectStartedEventArgs.GlobalProperties being not null and set. It will take a long time to move them to ProjectEvaluationFinished (needs to bump MSBuild dependency to 16.10). For now log GlobalProperties in both places (ProjectStarted and ProjectEvaluationFinished). Hopefully the deduplication will save us from any significant increase in binlog size. Fixes #6341
AraHaan
approved these changes
Apr 13, 2021
AndyGerlicher
approved these changes
Apr 13, 2021
Contributor
AndyGerlicher
left a comment
AndyGerlicher
left a comment
There was a problem hiding this comment.
Thanks! I verified that this does fix the crash in our 1ES telemetry logger.
cdmihai
approved these changes
Apr 13, 2021
Member
Author
|
No discernible impact on build times or binlog size. Dedup hid this overhead under the carpet. |
Forgind
approved these changes
Apr 13, 2021
Forgind
added
the
merge-when-branch-open
Contributor
|
FYI this fixes a crash in the 1ES telemetry logger. It would be great if we could get this in asap before people start hitting this. Fortunately it only happens on repos with the logger enabled (a few hundred) and using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some loggers depended on ProjectStartedEventArgs.GlobalProperties being not null and set. It will take a long time to move them to ProjectEvaluationFinished (needs to bump MSBuild dependency to 16.10).
For now log GlobalProperties in both places (ProjectStarted and ProjectEvaluationFinished). Hopefully the deduplication will save us from any significant increase in binlog size.
Fixes #6341