Fix project cache plugin exception handling#6345
Merged
benvillalobos merged 4 commits intodotnet:mainfrom Apr 23, 2021
Merged
Conversation
Forgind
approved these changes
Apr 18, 2021
| StringShouldContainSubstring(logger.FullLog, $"{AssemblyMockCache}: EndBuildAsync", expectedOccurrences: 1); | ||
| } | ||
|
|
||
| // TODO: this ain't right now is it? |
Member
There was a problem hiding this comment.
To be done in the follow-up PR, or is this leftover? 🤔
Contributor
Author
There was a problem hiding this comment.
Yup, followup-pr: #6368
This PR just fixes the exception handling part, follow-up PR does the logging.
benvillalobos
approved these changes
Apr 22, 2021
benvillalobos
added
the
merge-when-branch-open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The project cache plugin can fail with exceptions from any of its APIs. Currently some exceptions from certain APIs get lost and the build fails with no errors.
This PR ensures that:
Changes Made
BuildManager.ExecuteSubmission(BuildSubmission)always completes the build submission with the exception when it detects that it's running in a detached thread.BuildManager.BuildGraphobserves the exceptions captured above and rethrows them to mimic what happens whenExecuteSubmission(BuildSubmission)does not run in a detached thread.BuildManager.EndBuildmarks the overall build result as failed if exceptions are thrown inBM.EndBuild.Testing
Added unit tests to ensure that exceptions thrown from any possible plugin API are observable.
Notes
This is an intermediary implementation to avoid lost exceptions. A better implementation which I'm working on, builds upon this one and actually logs the plugin exceptions to the
LoggingServicein a similar way to which logger errors get handled.