Remove SolutionFilterName support

[Forgind]

We decided that adding support for a SolutionFilterName property was premature. The point of a solution filter is to permit loading or building only a subset of a more complicated solution file. Of note, however, it is not to permit changing behavior based on which subset is being built—if a full solution is buildable, any associated solution filter file should be as well. Furthermore, if that information is not properly propagated within Visual Studio, it may lead to different behavior when building from the command line versus Visual Studio.

[rainersigwald]

I think this is the right move. It's bad practice to have a difference in build behavior within a project based on the environment the project was built in, and adding this information just makes that more likely.

[benvillalobos]

There's one spot SolutionFilterName still exists. It's in a deprecated file, but it was added there so it should be removed from there.

C:\src\git\msbuild>rg -Fi "SolutionFilterName"
src\Deprecated\Engine\Solution\SolutionWrapperProject.cs
1611:                msbuildTask.SetParameterValue("Properties", "Configuration=%(Configuration); Platform=%(Platform); BuildingSolutionFile=true; CurrentSolutionConfigurationContents=$(CurrentSolutionConfigurationContents); SolutionDir=$(SolutionDir); SolutionExt=$(SolutionExt); SolutionFileName=$(SolutionFileName); SolutionName=$(SolutionName); SolutionFilterName=$(SolutionFilterName); SolutionPath=$(SolutionPath)");

[Forgind]

(Good catch 😁)