Update test-upload TargetFramework

[rainersigwald]

These should have been changed when we updated past .NET Core 2.1 but were missed.

Fixes these warnings:

Should be futureproof since it's just "upload everything that's not net472".

[benvillalobos]

I remember mulling this over. I think we can remove these steps entirely, artifact upload is already handled by:

  - task: PublishBuildArtifacts@1
    displayName: 'Publish Artifact: TestResults'
    inputs:
      PathtoPublish: 'artifacts/TestResults'
      ArtifactName: 'FullOnWindows Release test logs'
    continueOnError: true
    condition: always()

!**/UnitTests_net472.xml

Does this capture files that have been missed for some time?

Edit: I noticed it when opting into perf log capturing. The perf logs were being uploaded without an explicit yml task for it.

[Forgind]

LGTM!

[rainersigwald]

I think we can remove these steps entirely, artifact upload is already handled by:

This (test publish) is subtly distinct from that (artifact upload). This drives the results that appear in the test tab. When this works we should see way more tests there.

Does this capture files that have been missed for some time?

Yeah, since we moved off 2.1 😬

[benvillalobos]

This drives the results that appear in the test tab

😲 makes sense!

[rainersigwald]

Yeah, so: this run

versus last passed run