Don't move Properties and Items to ProjectEvaluationFinished if legacy loggers present#6520
Merged
rainersigwald merged 1 commit intovs16.10from Jun 8, 2021
Merged
Conversation
Member
Author
|
/asp run |
Forgind
approved these changes
Jun 7, 2021
…y loggers present Switch from the "use the new logic if any logger is present that supports it" to the more conservative "use the old logic if any logger doesn't support the new logic". There are legacy loggers such as the Azure DevOps logger that crash if ProjectStartedEventArgs.Properties is null. Both console loggers also need more work to properly support the new logic. Effectively the new logic will now only take place when the binary logger is the only logger.
936c270 to
794abcb
Compare
rainersigwald
approved these changes
Jun 7, 2021
Member
rainersigwald
left a comment
There was a problem hiding this comment.
Retargeted to 16.10 for servicing; applying Tactics label for servicing consideration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6498
Summary
Switch from the "use the new logic if any logger is present that supports it" to the more conservative "use the old logic if any logger doesn't support the new logic".
Customer impact
Customers who use MSBuild binary logs in conjunction with a legacy logger like one Azure DevOps provides for you would see a crash
Without this fix, there are two available workarounds:
Regression?
Yes, #6287 caused 16.10 to regress against 16.9 (and former).
Changes Made
Switch from the "use the new logic if any logger is present that supports it" to the more conservative "use the old logic if any logger doesn't support the new logic". Effectively the new logic will now only take place when the binary logger is the only logger.
Testing
Unit tests, inspection of state in debugger.
Risk
Low. Makes the validate escape-hatch codepath more common.