Fix *.* wildcard glob matching regression#6531
Closed
ladipro wants to merge 3 commits intodotnet:vs16.10from
Closed
Fix *.* wildcard glob matching regression#6531ladipro wants to merge 3 commits intodotnet:vs16.10from
ladipro wants to merge 3 commits intodotnet:vs16.10from
Conversation
Forgind
approved these changes
Jun 7, 2021
rainersigwald
approved these changes
Jun 7, 2021
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
As discussed offline, please retarget to 16.10 and we'll ask for servicing approval.
AR-May
approved these changes
Jun 7, 2021
ladipro
force-pushed
the
6502-fix-wildcard-glob-matching-16.11
branch
from
19c1e6d to
6bd221d
Compare
Member
Author
|
I have rebased to 16.10, fixed the new unit test to pass on Linux, and updated the description with the servicing template. |
Member
|
Merged this except the ref assembly nonsense in #6537. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6502
Summary
This change fixes a regression in glob matching where files without extension are erroneously not matched when taking a specific globbing code path.
Customer impact
Any customer who uses a glob pattern susceptible to the bug and has files without extensions in their source tree is affected. The bug was reported by external customers.
Regression?
Yes, caused by #6151 where glob matching was optimized which internally made it take a different code path.
Changes Made
Fixes the regression by properly handling
*.*to mean all files, not just files with a dot in the name. This convention is used in .NET APIs on all platforms and matches the pre-regression behavior.Testing
Added unit test coverage. Also verified locally with the repro provided by the original bug reporter.
Risk
Low. The star patterns are special-cased to mean all files, other patterns are unaffected.