Skip to content

16.11 release note update#6586

Merged
Forgind merged 5 commits into
dotnet:mainfrom
rainersigwald:relnotes-16.11
Aug 18, 2021
Merged

16.11 release note update#6586
Forgind merged 5 commits into
dotnet:mainfrom
rainersigwald:relnotes-16.11

Conversation

@rainersigwald
Copy link
Copy Markdown
Member

@rainersigwald rainersigwald commented Jun 17, 2021

  • 16.10.2 release notes
  • Update relnotes for 16.11

Forgind
Forgind approved these changes Jun 18, 2021
View reviewed changes
Comment thread documentation/Changelog.md Outdated
@rainersigwald @Forgind
Update documentation/Changelog.md
beba59e 
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
@benvillalobos
Copy link
Copy Markdown
Member

benvillalobos commented Jul 8, 2021

I plan on merging this with #6656 to avoid getting 2 QB approvals before GA

@rainersigwald
Copy link
Copy Markdown
Member Author

rainersigwald commented Jul 9, 2021

@benvillalobos this doesn't really have to go into 16.11 at all, just "somewhere". So it can go to main after 16.11 RTM.

@marcpopMSFT marcpopMSFT added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jul 9, 2021
@benvillalobos
Copy link
Copy Markdown
Member

benvillalobos commented Jul 9, 2021

Cherry-picked / squashed onto #6656

@benvillalobos
Copy link
Copy Markdown
Member

benvillalobos commented Jul 9, 2021

this doesn't really have to go into 16.11 at all, just "somewhere". So it can go to main after 16.11 RTM.

Did not read this before closing / cherry-picking. I'll stick it in vs16.11 since the work is done in that PR anyway. Reopening to get this into main docs eventually.

@benvillalobos benvillalobos reopened this Jul 9, 2021
@benvillalobos benvillalobos changed the base branch from vs16.11 to main July 9, 2021 17:52
@benvillalobos benvillalobos removed the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Jul 9, 2021
@Forgind
Copy link
Copy Markdown
Contributor

Forgind commented Aug 16, 2021

Anything you want to add before merging this? Want me to make some release notes for 17.0?

@rainersigwald
Copy link
Copy Markdown
Member Author

rainersigwald commented Aug 17, 2021

Anything you want to add before merging this?

Yeah, I completed the 16.11 notes.

Want me to make some release notes for 17.0?

Go for it.

@rainersigwald
Copy link
Copy Markdown
Member Author

rainersigwald commented Aug 17, 2021

Pushed https://github.com/dotnet/msbuild/releases/tag/v16.11.0 with the current contents.

eriawan
eriawan reviewed Aug 17, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@eriawan eriawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small feedback :)

Comment thread documentation/Changelog.md
## MSBuild 16.11.0

This version of MSBuild will ship with Visual Studio 2019 version 16.11.0 and .NET SDK 5.0.400.
This version of MSBuild shipped with Visual Studio 2019 version 16.11.0 and .NET SDK 5.0.400.
Copy link
Copy Markdown
Member

@eriawan eriawan Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: I think it should be is shipped or for better active instead of passive, should be rephrased using ships as:
This version of MSBuild ships with Visual Studio 2019 version 16.11.0 and .NET SDK 5.0.400.

Copy link
Copy Markdown
Member Author

@rainersigwald rainersigwald Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer past tense here because this release is in some ways just a pointer to the "standard" ways to get MSBuild: through VS or the .NET SDK.

Copy link
Copy Markdown
Member

@eriawan eriawan Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rainersigwald
thanks for your reply! ok, I understand now 🙂

Comment thread documentation/Changelog.md
#### Documentation
## MSBuild 16.10.2

This version of MSBuild shipped with Visual Studio 2019 version 16.10.2 and will ship with .NET SDK 5.0.302.
Copy link
Copy Markdown
Member

@eriawan eriawan Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as line 4 comment, should be is shipped unless it is emphasizing on the past state of 16.10.2

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Aug 17, 2021
@Forgind Forgind merged commit 46d8f9b into dotnet:main Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@eriawan eriawan eriawan left review comments

@Forgind Forgind Forgind approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rainersigwald @benvillalobos @Forgind @eriawan @marcpopMSFT