Use List<string> for excludes#6598
Merged
Merged
Conversation
Fixes AB#1344683
sharwell
changed the title
rainersigwald
changed the title
rainersigwald
approved these changes
Jun 21, 2021
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
I suspect there are several places in the lazy evaluator that could benefit from switching to ImmutableArray, since they're almost entirely manipulated in the Builder.
Forgind
suggested changes
Jun 21, 2021
These lists can eventually be converted to ImmutableSegmentedList<T>. See dotnet#6601.
sharwell
changed the title
benvillalobos
approved these changes
Jun 21, 2021
ladipro
approved these changes
Jun 21, 2021
Forgind
approved these changes
Jun 21, 2021
Forgind
added
the
merge-when-branch-open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My preference is to use
ImmutableSegmentedList<string>for this (avoids the Large Object Heap and avoids the array copy inToImmutable()), but I haven't finished implementing it yet in Microsoft.CodeAnalysis.Collections. In the mean time, I've corrected an acute performance problem by usingImmutableArray<string>List<string>instead ofImmutableList<string>.Fixes AB#1344683