Recalculate MSBuild path from VS Root#6746
Merged
Merged
Conversation
A 64-bit application is now (after dotnet#6683) getting a good VS root path, but may still use toolsets from the wrong directory, because if it loaded (AnyCPU) assemblies from the 'x86' location it wouldn't pass a path containing �md64 to the BuildEnvironment constructor, so the logic there wouldn't find the right MSBuildToolsDirectory and config file. Fix this in the lowest-impact way by rederiving the path to the 'correct' MSBuild.exe from the VS root and passing that to the BuildEnvironment constructor.
ladipro
approved these changes
Aug 10, 2021
Forgind
added
the
merge-when-branch-open
benvillalobos
approved these changes
Aug 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A 64-bit application is now (after #6683) getting a good VS root path,
but may still use toolsets from the wrong directory, because if it
loaded (AnyCPU) assemblies from the 'x86' location it wouldn't pass
a path containing amd64 to the BuildEnvironment constructor, so
the logic there wouldn't find the right MSBuildToolsDirectory and
config file.
Fix this in the lowest-impact way by rederiving the path to the
'correct' MSBuild.exe from the VS root and passing that to the
BuildEnvironment constructor.
Fixes #6681.