-
Notifications
You must be signed in to change notification settings - Fork 1.4k
ProjectReference protocol documentation updates #6892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ladipro
merged 8 commits into
dotnet:main
from
drewnoakes:update-ProjectReference-Protocol-docs
Oct 13, 2021
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d3d9e90
ProjectReference protocol documentation updates
drewnoakes 2517690
Remove unused target
benvillalobos 4d8af08
Remove PlatformTarget= usage from docs
benvillalobos c84edec
Remove gettargetframeworkproperties from doc
benvillalobos a5ceebf
Only report MSB4181 when not on warnandcontinue. Always set haslogged…
benvillalobos 4f7381e
Revert "Remove unused target"
benvillalobos 8dac1ba
Mark gettargetframeworkproperties obsolete
benvillalobos 2717192
Revert "Only report MSB4181 when not on warnandcontinue. Always set h…
benvillalobos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this makes me nervous. It doesn't help that much (one empty target is no big deal), and might cause breaks (if someone's calling it explicitly).
To be conservative we could minimize the comment to "Obsolete; present only for theoretical backward compatibility".