Skip to content

Final Branding For 17.0 GA#6902

Merged
ladipro merged 2 commits into
dotnet:vs17.0from
benvillalobos:vs17.0-release-branding
Oct 21, 2021
Merged

Final Branding For 17.0 GA#6902
ladipro merged 2 commits into
dotnet:vs17.0from
benvillalobos:vs17.0-release-branding

Conversation

@benvillalobos
Copy link
Copy Markdown
Member

No description provided.

@benvillalobos
Copy link
Copy Markdown
Member Author

When 17.0 is fast forwarded to main, this should be a PR with a single commit.

@benvillalobos benvillalobos changed the base branch from vs17.0 to main October 1, 2021 21:36
@benvillalobos benvillalobos changed the base branch from main to vs17.0 October 1, 2021 21:36
Comment thread eng/Versions.props Outdated
<AssemblyVersion>15.1.0.0</AssemblyVersion>
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
<DotNetUseShippingVersions>true</DotNetUseShippingVersions>
<DotNetUseShippingVersions>true</DotNetUseShippingVersions><DotNetFinalVersionKind>release</DotNetFinalVersionKind>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go on the VersionPrefix line.

Copy link
Copy Markdown
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now but I'm leaving it red so that we don't merge too soon. If I'm out and it's time, go ahead.

@ladipro ladipro merged commit c9eb9dd into dotnet:vs17.0 Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants