Loosen version comparisons in loading assemblies#7042
Merged
Conversation
rainersigwald
approved these changes
Nov 17, 2021
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
Change looks good.
CI? I had trouble repro'ing this.
Did you try building the SDK repo at the commit that Daniel suggested in the bug?
Contributor
Author
Essentially yes. I had trouble finding that exact commit, so I walked back to an earlier commit and layered all the relevant changes on top of it, but the code should have been identical. |
benvillalobos
approved these changes
Nov 19, 2021
Forgind
added
the
merge-when-branch-open
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Feb 24, 2022
This reverts commit 3bb10b7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6993
Context
See issue.
Changes Made
Switched to also load if the found assembly is greater than what was requested.
Testing
CI? I had trouble repro'ing this.