Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Common.globalconfig
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ dotnet_diagnostic.CA2153.severity = none
dotnet_diagnostic.CA2201.severity = none

# Instantiate argument exceptions correctly
dotnet_diagnostic.CA2208.severity = suggestion
dotnet_diagnostic.CA2208.severity = warning

# Non-constant fields should not be visible
dotnet_diagnostic.CA2211.severity = none
Expand Down
2 changes: 1 addition & 1 deletion src/Build.OM.UnitTests/TransientIO.cs
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public string GetAbsolutePath(string relative)
var absolute = Path.GetFullPath(Path.IsPathRooted(relative) ? relative : Path.Combine(tempRoot, relative));
if (!IsControled(absolute))
{
throw new ArgumentException(nameof(relative));
throw new ArgumentException("Either the path is invalid or it is not rooted to RootFolder.", nameof(relative));
}

return absolute;
Expand Down
3 changes: 2 additions & 1 deletion src/StringTools/InternableString.Simple.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ public static string AsSpan<T>(this T[] array, int start, int length)
{
return new string(charArray, start, length);
}
throw new ArgumentException(nameof(array));

throw new ArgumentException("array is not char array.", nameof(array));
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/Tasks/ManifestUtil/TrustInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ public bool IsFullTrust
public PermissionSet PermissionSet
{
get => GetOutputPermissionSet();
set => _outputPermissionSet = value ?? throw new ArgumentNullException("PermissionSet cannot be set to null.");
set => _outputPermissionSet = value ?? throw new ArgumentNullException(nameof(value), "PermissionSet cannot be set to null.");
}
#endif

Expand Down