Skip to content

CA2016 Forward the 'CancellationToken' parameter to methods that take… #7188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Forgind merged 4 commits into from
Jan 10, 2022
Merged

CA2016 Forward the 'CancellationToken' parameter to methods that take… #7188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07dcc06
CA2016 Forward the 'CancellationToken' parameter to methods that take…
elachlan Dec 30, 2021
af77c35
Revert CodeAnalysis.ruleset
elachlan Jan 8, 2022
d786931
merge master
elachlan Jan 8, 2022
ea95d55
enable warning on CA2016
elachlan Jan 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Common.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ dotnet_diagnostic.CA2014.severity = warning
dotnet_diagnostic.CA2015.severity = warning

# Forward the 'CancellationToken' parameter to methods that take one
dotnet_diagnostic.CA2016.severity = suggestion
dotnet_diagnostic.CA2016.severity = warning

# Review SQL queries for security vulnerabilities
dotnet_diagnostic.CA2100.severity = none
Expand Down
2 changes: 1 addition & 1 deletion src/Build.UnitTests/ProjectCache/ProjectCacheTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ public override async Task<CacheResult> GetCacheResultAsync(

if (_projectQuerySleepTime is not null)
{
await Task.Delay(_projectQuerySleepTime.Value);
await Task.Delay(_projectQuerySleepTime.Value, cancellationToken);
}

QueryStartStops.Enqueue(queryId);
Expand Down